Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a newline to the result to remove the percentage in the CLI output #108

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

mrwnmncd
Copy link
Contributor

@mrwnmncd mrwnmncd commented Aug 18, 2024

When installed globally via npm, yarn, or bun, the output returns a ULID but with a percentage at the end as it uses process.stdout.write instead of the common console.log. This, however, does not append a new line insertion which explains why there is a percent sign at the ened of every result.

As a fix, a new line character at the end of the write function is inserted to omit the percent sign and return the generated ULID only.

Screenshot 2024-08-18 at 11 40 01 PM

@perry-mitchell perry-mitchell merged commit c5c4231 into ulid:master Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants